[Bug 978489] Review Request: dleyna-connector-dbus - D-Bus connector for dLeyna services

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=978489

--- Comment #4 from Debarshi Ray <debarshir at redhat.com> ---
Spec: http://rishi.fedorapeople.org/dleyna-connector-dbus.spec
SRPM: http://rishi.fedorapeople.org/dleyna-connector-dbus-0.1.0-2.fc19.src.rpm

>> I don't know either. dLeyna supports different IPC mechanisms (see
>> connector-name in /etc/dleyna-renderer-service.conf) via a plugin
>> architecture. This particular file implements support for D-Bus.
> 
> What will load this plugin?
> 
> If it's something which just loads whatever is installed and configured,
> then there wouldn't be any requirement, and as such I'd filter the Provides
> out.
> 
> If it's something that needs to link against it, then the Provides should
> stay.

I think you were right in saying that they should be filtered. After reading
https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering I
think that it matches the Pidgin plugin scenario. Things like dleyna-renderer
load this connector plugin at run-time. If the plugin is absent, the
dleyna-renderer service will start and exit immediately.

Interestingly the mechanism for loading the connector plugins are in
dleyna-core (grep for dleyna_connector_get_interface).

Since dleyna-connector-dbus requires dleyna-core, we can't possibly have
dleyna-core require the connector because it will be a circular dependency.

Hence I filtered out the provides as you suggested initially.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sDGqTSqHW5&a=cc_unsubscribe