[Bug 984605] Review Request: nwchem - Delivering High-Performance Computational Chemistry

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=984605

--- Comment #4 from marcindulak <Marcin.Dulak at gmail.com> ---
(In reply to Susi Lehtola from comment #3)
> The package MUST conform to the MPI guidelines. Also, you should add an
> mpich2 flavor.
OK - i found this
http://fedoraproject.org/wiki/Packaging:MPI#Packaging_of_MPI_software but can
you suggest me a recent, good style MPI software spec as a template? I think i
will drop el5 - it does not use this new packaging convention.
> 
> **
> 
> # openmpi needs ssh
> BuildRequires:		openssh-clients
> 
> This doesn't seem right. OpenMPI works just fine without ssh.
i needed that on build.opensuse.org, but confirmed not needed for build
on localhost.
> 
> **
> 
> 
> %if 0%{?el5}
> BuildRequires:		blas-devel
> Requires:		blas
> %else
> BuildRequires:		atlas-devel
> Requires:		atlas
> %endif
> 
> This is unnecessary. BuildRequires: atlas-devel is available also on EL5.
> Besides, the explicit require is unnecessary and thus banned by guidelines.
OK
> 
> **
> 
> You don't need to conditionalize the BuildRoot etc statements for EL5. The
> statements work just fine on newer distros as well.
but fedora-review complains about some of them, so i got suggestion to include
them conditionally for el5 in bug #976886 comment #4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=s7J7EIQkCq&a=cc_unsubscribe