[Bug 986172] Review Request: jackson-databind - General data-binding package for Jackson (2.x)

bugzilla at redhat.com bugzilla at redhat.com
Mon Jul 22 07:33:07 UTC 2013


https://bugzilla.redhat.com/show_bug.cgi?id=986172

Simone Caronni <negativo17 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #2 from Simone Caronni <negativo17 at gmail.com> ---
(In reply to Simone Caronni from comment #1)
> [!]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
>      Note: Found : Packager: Simone Caronni <negativo17 at gmail.com>

That's my local .rpmmacros.

> [!]: If the source package does not include license text(s) as a separate
> file
>      from upstream, the packager SHOULD query upstream to include it.
> [!]: Package does not include license text files separate from upstream.

Fixed in spec file; has it been reported upstream?

> [!]: If the package is a rename of another package, proper Obsoletes and
>      Provides are present.
> jackson-databind.noarch: W: self-obsoletion jackson2-databind <= 2.2.2
> obsoletes jackson2-databind = 2.2.2

Can you fix this? Spec file should read:

Obsoletes:     jackson2-databind < %{version}
Provides:      jackson2-databind = %{version}

As per:
https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages

Please fix it before importing. Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zO31IzHuUx&a=cc_unsubscribe


More information about the package-review mailing list