[Bug 979738] Review Request: crawl-sdl - free roguelike game of exploration and treasure-hunting in dungeons

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=979738

Christopher Meng <cickumqt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
           Assignee|cickumqt at gmail.com          |nobody at fedoraproject.org
              Flags|fedora-review?              |

--- Comment #7 from Christopher Meng <cickumqt at gmail.com> ---
I'm sorry I can't sponsor you, so here is an informal review of this package:

1. From spec file itself:

- Summary tag is too long;

- Remove rm -rf %{buildroot} in %install section;

- Remove INSTALL.txt in %doc of %files section;

- description field is not good. Please change it to less than 80 chars per
line;

See: http://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description

- Can you send the desktop file to upstream?

2. From the package itself:

- License is complex, but please 

  - Notify upstream to fix the incorrect license;
  - Please check the bugzilla attachment I just uploaded, make sure the license
is correct.

- Large data in /usr/share should live in a noarch subpackage if package is
     arched.
     Note: Arch-ed rpms have a total of 12922880 bytes in /usr/share.

So consider a -data subpackage to include all files under datadir;

I'll do another informal review once you correct these.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mXl1exQTXF&a=cc_unsubscribe