[Bug 969700] Review Request: libccp4 - Library providing specific CCP4 functionality

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=969700

--- Comment #2 from Tim Fenn <tim.fenn at gmail.com> ---
Thanks for the tips, comments and quick response, Mario!

(In reply to Mario Blättermann from comment #1)
> 
> Spelling errors to be addressed:
> 
> subcomponents → sub components
> centred → centered
> 

Done.

> 
> If you set an "Obsoletes" tag, you should also use a "Provides" tag for the
> same package, to get a proper upgrade path. Because of that we recognize
> your package as the successor of all gpp4 versions, explicite versioning is
> unneeded.
> 

Done - edited spec contains:

Provides: libgpp4 = %{version}-%{release}
Obsoletes: libgpp4 < %{version}-%{release}

seem OK?

> 
> The exit() call is not up to you to fix, but should be filed as an upstream
> bug.
> 

OK - will do.

> 
> Some parts of the spec file are obsolete for Fedora and EPEL <=5:
> 
> * The initial cleaning of %{buildroot} in %install
> * The %clean section
> * The %defattr line in %files
> 

cleaned up.

> 
> Requires: %{name} = %{version}-%{release}
> has to be
> Requires: %{name}%{?_isa} = %{version}-%{release}
> 

Fixed.

> 
> To require pkgconfig for the -devel package is unneeded, see what rpm adds
> automatically:
> 

removed.

> 
> Your package is LGPL licensed. This is OK so far, but you have to ship
> COPYING.LESSER instead of COPYING (which addresses the GPLv3). The latter
> doesn't affect any file in the tarball and can be ignored:
> 

Ah, thanks - done!

updated files:

Spec URL: https://sites.google.com/site/timfenn/libccp4.spec
SRPM URL: https://sites.google.com/site/timfenn/libccp4-6.3.1-2.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EM1Pnt63mr&a=cc_unsubscribe