[Bug 882481] Review Request: python-doit - Automation Tool

bugzilla at redhat.com bugzilla at redhat.com
Wed Jun 5 08:25:09 UTC 2013


https://bugzilla.redhat.com/show_bug.cgi?id=882481

--- Comment #20 from José Matos <jamatos at fc.up.pt> ---
(In reply to Mario Blättermann from comment #18)
> The files LICENSE and README should appear in both python2 and python3
> versions. One can install them independently from each other, so the python3
> package would remain without license declaration and basic docs. TODO.txt
> should be added to the -docs subpackage.
> Or another way for the docs: Move all doc files to the -docs package and
> mark it as required by the python2 and python3 packages. This way the docs
> would be always present, independently from which python version is used.

I chose the first option as it is the least invasive:

Spec URL: http://jamatos.fedorapeople.org/python-doit.spec
SRPM URL: http://jamatos.fedorapeople.org/python-doit-0.21.0-2.fc20.src.rpm

To have all the subpackages depending on -doc would defeat the reason to have a
separate -doc in the first place.

(In reply to Christopher Meng from comment #19)
> (In reply to Mario Blättermann from comment #18)
> > The files LICENSE and README should appear in both python2 and python3
> > versions. One can install them independently from each other, so the python3
> > package would remain without license declaration and basic docs. TODO.txt
> > should be added to the -docs subpackage.
> > Or another way for the docs: Move all doc files to the -docs package and
> > mark it as required by the python2 and python3 packages. This way the docs
> > would be always present, independently from which python version is used.
> 
> Nice suggestion.
> 
> BTW, this package seems has test problem during %check section, can we
> ignore this section?

We should not but there is a strange random problem as it is documented in the
package.

It fails sometimes in one or two places and sometimes it works. I took a look
into debian package and there is not any special code for this case and after
spending lots of time with it I am lost here.

> I need this package for another package, so...

FWIW I will be busy until next week so I will return to this in one week.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZkQC5bTOsi&a=cc_unsubscribe


More information about the package-review mailing list