[Bug 972590] Review Request: sugar-starchart - Display a map of the sky showing the position of the visible stars

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=972590

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody at fedoraproject.org    |panemade at gmail.com
              Flags|                            |fedora-review?

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> ---
Review:-

+ Mock build successful for f20

- rpmlint on generated rpms gave
sugar-starchart.noarch: E: script-without-shebang
/usr/share/sugar/activities/StarChart.activity/activity/activity.info
sugar-starchart.noarch: E: script-without-shebang
/usr/share/sugar/activities/StarChart.activity/activity/StarChart.svg
sugar-starchart.noarch: E: wrong-script-end-of-line-encoding
/usr/share/sugar/activities/StarChart.activity/activity/StarChart.svg
2 packages and 0 specfiles checked; 3 errors, 0 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball     :
c5e1e4275303b8d60f335a5d73804535daebcb3c312e89546436ec478192ec94
upstream tarball :
c5e1e4275303b8d60f335a5d73804535daebcb3c312e89546436ec478192ec94

+ License is valid and its text is available

+ rest looks as per packaging guidelines


Suggestions
1) As suggested in previous other reviews change
--prefix=%{buildroot}/%{_prefix} to --prefix=%{buildroot}%{_prefix}


2) rpmlint errors can be fixed by adding following line in %prep
chmod 644 activity/*

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4NZmBrwG0K&a=cc_unsubscribe