[Bug 903246] Review Request: cpopen - Creates a subprocess in simpler safer manner

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=903246

Douglas Schilling Landgraf <dougsland at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #7 from Douglas Schilling Landgraf <dougsland at redhat.com> ---
Hi Yaniv,

Your package looks good but please handle the rpmlint output:

Checking: python-cpopen-1.2.2-1.fc18.x86_64.rpm
python-cpopen.x86_64: W: incoherent-version-in-changelog 1.2.2 ['1.2.2-1.fc18',
'1.2.2-1']

Your release looks like wrong:
Release:        1%{?dist}

%changelog
* Wed May 08 2013 Yaniv Bronhaim <ybronhei at redhat.com> 1.2.2

More info:
http://fedoraproject.org/wiki/ParagNemade/CommonRpmlintErrors#incoherent-version-in-changelog

python-cpopen.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/cpopen.so cpopen.so()(64bit)

More info:
http://fedoraproject.org/wiki/Common_Rpmlint_issues#private-shared-object-provides
https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Preventing_files.2Fdirectories_from_being_scanned_for_deps_.28pre-scan_filtering.29

python-cpopen.x86_64: W: no-documentation
You might consider include README, COPYING, AUTHORS into %doc

Also, to be sponsor you need to provide some informal reviews, just point the
urls and I will check.

To help on such task you can use:
http://fedoraproject.org/wiki/Packaging:ReviewGuidelines
http://fedoraproject.org/wiki/Packaging:Python
http://fedoraproject.org/wiki/Packaging:Java
https://fedorahosted.org/FedoraReview/

Please let me know if you have any additional questions.

@Michael, thanks for your help here.

Thanks
Douglas

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uHBXcV0gUw&a=cc_unsubscribe