[Bug 973904] Review Request: libserf - High-Performance Asynchronous HTTP Client Library

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=973904

--- Comment #1 from Remi Collet <fedora at famillecollet.com> ---
QUick notes:

%package -n     devel

Need to remove the -n

BuildRequires:

Why openldap-devel (don't see any ldap stuff in this package, no lber.h, ldap.h
or ldif.h include)
Why expat-devel... (no expat.h include)

=> Ok, both are used in the result .so but can probably be omitted, no include
of the provided headers, and will be pulled by apr.

Auto dependencies are broken.
Setting right to 755 the library should solves this.

%files
%{_libdir}/*.so.*

I don't really like too large wildcard.
%{_libdir}/libserf-1.so.0*

As this is more explicit, it will also help to detect any soname change.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=s2MGgrFn3y&a=cc_unsubscribe