[Bug 962651] Re-Review Request: bamf - Application matching framework

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=962651

Praveen Kumar <kumarpraveen.nitdgp at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |
              Flags|                            |fedora-review+

--- Comment #10 from Praveen Kumar <kumarpraveen.nitdgp at gmail.com> ---
Looks like below issue is fix now.
 [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
 [x]: Each %files section contains %defattr if rpm < 4.4
 [!]Package do not use a name that already exist
  Note: A package already exist with this name, please check
  https://admin.fedoraproject.org/pkgdb/acls/name/bamf
  See:
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names
But it's not a blocker since it is a re-review request after package drop.

Please update upstream about License issue and update spec accordingly.

========================================================
APPROVED
========================================================

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zUlN8DsArp&a=cc_unsubscribe