[Bug 974492] Review Request: php-xmlseclibs - PHP library for XML Security

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=974492

--- Comment #6 from Remi Collet <fedora at famillecollet.com> ---
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: SourceX tarball generation or download is documented.
[x]: %check is present and all tests pass.

[!]: Requires correct, justified where necessary.

Still not correct.
>From http://fedoraproject.org/wiki/Packaging:PHP#Extensions_Requires

"PHP extensions must have a Requires on ALL of the dependent extensions."

So should , according to phpci, should be, else please justify
php-dom
php-hash
php-libxml
php-mcrypt
php-openssl
(and remove php-xml)

[!]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.

The request is fine but not enough. From
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

* Include a copy of what they believe the license text is intended to be...
* Choose not to package that software for Fedora. 

So I propose to wait a little from upstream on your filed bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UyhIBW5yvJ&a=cc_unsubscribe