[Bug 888385] Review Request: python-yapsy - Fat-free DIY Python plugin management toolkit

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=888385

--- Comment #4 from José Matos <jamatos at fc.up.pt> ---
(In reply to Mario Blättermann from comment #3)
> The tarball contains an upstream egg, you have to delete it before building
> the package so that it gets rebuilt:
> 
> %prep
> %setup -q -n Yapsy-%{version}-pythons2n3
> rm -rf *.egg-info
> 
> See http://fedoraproject.org/wiki/Packaging:Python_Eggs#Upstream_Eggs for
> more info.

I noticed it the first time but forgot to remove it. Mea culpa. :-)

> Don't mix %{buildroot} and $RPM_BUILD_ROOT in the same spec file.

I was surprised when I noticed the $ version in there. :-)

> $ rpmlint -i -v *
> python-yapsy.src: I: checking
> python-yapsy.src: W: spelling-error %description -l en_US customised ->
> customized, customize, accustomed
> The value of this tag appears to be misspelled. Please double-check.
> 
> Please fix the spelling error:
> customised → customized

Done.

I have updated the package to the latest stable version together with all the
fixes you proposed.

Spec URL: http://jamatos.fedorapeople.org/python-yapsy.spec
SRPM URL: http://jamatos.fedorapeople.org/python-yapsy-1.10.2-1.fc20.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hlNXn8qnry&a=cc_unsubscribe