[Bug 979332] Review Request: libpqtypes - Software extension to the PostgreSQL libpq interface

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=979332

--- Comment #2 from Volker Fröhlich <volker27 at gmx.at> ---
The .so symlink belongs into the devel sub-package.

Please include AUTHORS and ChangeLog as documentation.

Commonly the %package and %description sections are all before the prep
section.

Your build appends -O3 to the Fedora flags. To my knowledge, that results in O3
being used.

The group seems wrong to me, as this is no application.

You've got two percent signs in from of description devel!

Use the name and version macro in Source0 and potentially in the files section.

rm -rf $RPM_BUILD_ROOT is obsolete and can be removed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=x5A9W58QTD&a=cc_unsubscribe