[Bug 911229] Review Request: nodejs-vows - Asynchronous behaviour-driven development (BDD) and continuous integration

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=911229

--- Comment #2 from Jamie Nguyen <jamielinux at fedoraproject.org> ---
> lib/utils/wildcard.js - under Apache 2.0

Added ASL 2.0 to License tag.


> nodejs-vows.src: W: spelling-error Summary(en_US) behaviour -> behavior

Argh. I just grepped to find more occurrences. Will fix in nodejs-expect and
nodejs-jasmine-node review requests.


> nodejs-vows.noarch: W: no-manual-page-for-binary vows

I actually don't think anyone will really expect vows to be at /usr/bin/vows so
I've removed the symlink.


Spec URL: http://jamielinux.fedorapeople.org/mocha/nodejs-vows.spec
SRPM URL:
http://jamielinux.fedorapeople.org/mocha/SRPMS/nodejs-vows-0.7.0-2.fc18.src.rpm


> lib/assert/error.js - adapted from mocha
> lib/assert/utils.js - taken from node/lib/assert.js
> lib/utils/wildcard.js - looks like it may have come from somewhere?
> lib/vows/coverage/report-html.js - adapted from mocha

Not really sure what to do about these. utils.js looks like yet another
slightly modified deepEqual :(

Any suggestions?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qWStoq9YjH&a=cc_unsubscribe