[Bug 889011] Review Request: rubygem-asciidoctor - A pure Ruby implementation of AsciiDoc

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=889011

--- Comment #12 from Vít Ondruch <vondruch at redhat.com> ---
(In reply to comment #11)
> I've updated the package to restore the require Ruby line as "Requires:
> ruby(release)".

You should use also the %gem_install macro then.

> Spec URL:
> https://raw.github.com/asciidoctor/rubygem-asciidoctor-rpm/master/rubygem-
> asciidoctor.spec
> SRPM URL:
> https://github.com/asciidoctor/rubygem-asciidoctor-rpm/raw/master/srpms/
> rubygem-asciidoctor-0.1.1-1.fc18.src.rpm
> 
> I don't have a F19 box setup, nor am I familiar with how to get one.

You don't need F19 box, mock is enough: 

http://fedoraproject.org/wiki/Projects/Mock
http://fedoraproject.org/wiki/Using_Mock_to_test_package_builds

It is good idea to get familiar with mock, since mock is used by Koji for
builds, it allows you to maintain packages for several Fedora, EPEL or RHEL
releases and it allows you to build your package in clean environment.

> Is that just rawhide?

The ruby(release) is just in Rawhide, for older releases, you should use
ruby(abi) = 1.9.1 or something similar. The %gem_install macro was backported
into older Fedoras, so you should be able to use it everywhere.

> how do I maintain that spec file separate from F18? Do I use a branch in the
> git repository?

Branch is one way, other possibility is conditionalize your spec. It depends on
preferences. If there is not much differences (for you just the ruby(abi) vs
ruby(release)) I would suggest to use conditions, such as:

%if 0%{?fedora} <= 18
Requires: ruby(abi) = 1.9.1
BuildRequires: ruby(abi) = 1.9.1
%else
Requires: ruby(release)
BuildRequires: ruby(release)
%endif

If the differences should be bigger, then the branch is good option. There is
no "better way", it is your choice. However, the conditions tends to make the
spec file harder to read.

Also, please note that for the moment, you need to build the package as 'fedpkg
build --target=f19-ruby', otherwise your dependencies will not be satisfied.
This is just temporary thing, please see Ruby-SIG mailing list for more
information.

> Yes, I still need to be sponsered. My FAS account is mojavelinux.

You are sponsored now.

> Let me know what step I need to do next.

You should continue with importing package into SCM [1]. Please let know
anytime if you need more guidance.


[1]
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=a55CLKHJmQ&a=cc_unsubscribe