[Bug 910150] Review Request: nodejs-express - Sinatra inspired web development framework for Node.js

bugzilla at redhat.com bugzilla at redhat.com
Sat Mar 16 00:06:03 UTC 2013 

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910150

--- Comment #3 from T.C. Hollingsworth <tchollingsworth at gmail.com> ---
Sorry for the delay, I was beating my head up against the wall trying to
figure out why mock wasn't working the other day, and it turned out it was
becasue there were no packages in the repository whatsoever!
http://lists.fedoraproject.org/pipermail/devel/2013-March/180065.html

Package Review
==============

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed

Status: NEEDS WORK

==== Issues ====

[!]: Latest version (3.1.0) is not packaged.

     Please package the latest version or provide a rationale for packaging an
     older version.

===== Things to Consider ====

[ ]: The command line utility `express` does not have a man page.

     Consider working with upstream to include one.

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.

MIT in LICENSE file, OK.

[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
     Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[-]: Large documentation must go in a -doc subpackage.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[x]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[!]: SourceX / PatchY prefixed with %{name}.
     Note: Source0 (express-3.1.0.tgz) Source1 (tests-3.1.0.tar.bz2) Source10
     (dl-tests.sh)
[x]: SourceX is a working URL.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.

Disabled, missing deps so OK.

[x]: Packages should try to preserve timestamps of original installed files.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
[-]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.

Rpmlint
-------
Checking: nodejs-express-3.1.0-2.fc20.src.rpm
          nodejs-express-3.1.0-2.fc20.noarch.rpm
nodejs-express.src: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-express.src: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-express.src: W: spelling-error %description -l en_US unopinionated ->
opinionated
nodejs-express.src: W: strange-permission dl-tests.sh 0755L
nodejs-express.src: W: invalid-url Source1: tests-3.1.0.tar.bz2
nodejs-express.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-express.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-express.noarch: W: spelling-error %description -l en_US unopinionated ->
opinionated
nodejs-express.noarch: W: only-non-binary-in-usr-lib
nodejs-express.noarch: W: dangling-symlink
/usr/lib/node_modules/express/node_modules/cookie-signature
/usr/lib/node_modules/cookie-signature
nodejs-express.noarch: W: dangling-symlink
/usr/lib/node_modules/express/node_modules/buffer-crc32
/usr/lib/node_modules/buffer-crc32
nodejs-express.noarch: W: dangling-symlink
/usr/lib/node_modules/express/node_modules/connect
/usr/lib/node_modules/connect
nodejs-express.noarch: W: dangling-symlink
/usr/lib/node_modules/express/node_modules/methods
/usr/lib/node_modules/methods
nodejs-express.noarch: W: dangling-symlink
/usr/lib/node_modules/express/node_modules/mkdirp /usr/lib/node_modules/mkdirp
nodejs-express.noarch: W: dangling-symlink
/usr/lib/node_modules/express/node_modules/range-parser
/usr/lib/node_modules/range-parser
nodejs-express.noarch: W: dangling-symlink
/usr/lib/node_modules/express/node_modules/commander
/usr/lib/node_modules/commander
nodejs-express.noarch: W: dangling-symlink
/usr/lib/node_modules/express/node_modules/fresh /usr/lib/node_modules/fresh
nodejs-express.noarch: W: dangling-symlink
/usr/lib/node_modules/express/node_modules/cookie /usr/lib/node_modules/cookie
nodejs-express.noarch: W: dangling-symlink
/usr/lib/node_modules/express/node_modules/send /usr/lib/node_modules/send
nodejs-express.noarch: W: dangling-symlink
/usr/lib/node_modules/express/node_modules/debug /usr/lib/node_modules/debug
nodejs-express.noarch: W: no-manual-page-for-binary express
2 packages and 0 specfiles checked; 0 errors, 21 warnings.

Consider asking upstream or adding a manpage, everything else is false
positive.


Rpmlint (installed packages)
----------------------------
# rpmlint nodejs-express
nodejs-express.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-express.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-express.noarch: W: spelling-error %description -l en_US unopinionated ->
opinionated
nodejs-express.noarch: W: only-non-binary-in-usr-lib
nodejs-express.noarch: W: dangling-symlink
/usr/lib/node_modules/express/node_modules/cookie-signature
/usr/lib/node_modules/cookie-signature
nodejs-express.noarch: W: dangling-symlink
/usr/lib/node_modules/express/node_modules/buffer-crc32
/usr/lib/node_modules/buffer-crc32
nodejs-express.noarch: W: dangling-symlink
/usr/lib/node_modules/express/node_modules/connect
/usr/lib/node_modules/connect
nodejs-express.noarch: W: dangling-symlink
/usr/lib/node_modules/express/node_modules/methods
/usr/lib/node_modules/methods
nodejs-express.noarch: W: dangling-symlink
/usr/lib/node_modules/express/node_modules/mkdirp /usr/lib/node_modules/mkdirp
nodejs-express.noarch: W: dangling-symlink
/usr/lib/node_modules/express/node_modules/range-parser
/usr/lib/node_modules/range-parser
nodejs-express.noarch: W: dangling-symlink
/usr/lib/node_modules/express/node_modules/commander
/usr/lib/node_modules/commander
nodejs-express.noarch: W: dangling-symlink
/usr/lib/node_modules/express/node_modules/fresh /usr/lib/node_modules/fresh
nodejs-express.noarch: W: dangling-symlink
/usr/lib/node_modules/express/node_modules/cookie /usr/lib/node_modules/cookie
nodejs-express.noarch: W: dangling-symlink
/usr/lib/node_modules/express/node_modules/send /usr/lib/node_modules/send
nodejs-express.noarch: W: dangling-symlink
/usr/lib/node_modules/express/node_modules/debug /usr/lib/node_modules/debug
nodejs-express.noarch: W: no-manual-page-for-binary express
1 packages and 0 specfiles checked; 0 errors, 16 warnings.
# echo 'rpmlint-done:'

Same as above.

Requires
--------
nodejs-express-3.1.0-2.fc20.noarch.rpm (rpmlib, GLIBC filtered):

    nodejs(engine)
    npm(buffer-crc32) < 1
    npm(buffer-crc32) >= 0.1
    npm(commander) < 1.2
    npm(commander) >= 1.1
    npm(connect) < 2.8
    npm(connect) >= 2.7.2
    npm(cookie) = 0.0.5
    npm(cookie-signature) = 0.0.1
    npm(debug)
    npm(fresh) = 0.1.0
    npm(methods) = 0.0.1
    npm(mkdirp) < 0.4
    npm(mkdirp) >= 0.3
    npm(range-parser) = 0.0.4
    npm(send) = 0.1.0

OK

Provides
--------
nodejs-express-3.1.0-2.fc20.noarch.rpm:

    nodejs-express = 3.1.0-2.fc20
    npm(express) = 3.1.0

OK

MD5-sum check
-------------
http://registry.npmjs.org/express/-/express-3.1.0.tgz :
  CHECKSUM(SHA256) this package     :
3dd5ff44601865202b8c48103dafc0fe855dc17c7668cb1f9c9ce8bda0c5b82d
  CHECKSUM(SHA256) upstream package :
3dd5ff44601865202b8c48103dafc0fe855dc17c7668cb1f9c9ce8bda0c5b82d

OK

Generated by fedora-review 0.3.1 (f4bc12d) last change: 2012-10-16
Buildroot used: fedora-rawhide-vanilla-x86_64
Command line :./try-fedora-review -b910150

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3uM77KgnFI&a=cc_unsubscribe

More information about the package-review mailing list