[Bug 882559] Review Request: mate-file-manager-image-converter - MATE Desktop file manager image converter plugin

Tue Mar 19 20:50:17 UTC 2013

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=882559

Wolfgang Ulbrich <chat-to-me at raveit.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |
              Flags|                            |fedora-review+

--- Comment #14 from Wolfgang Ulbrich <chat-to-me at raveit.de> ---
APPROVED !

can you do some changes before git push.
SHOULD items
- add Requires: mate-file-manager
- do a pull request at upstream
Checking: mate-file-manager-image-converter-1.5.0-1.fc20.x86_64.rpm
mate-file-manager-image-converter.x86_64: W: spelling-error %description -l
en_US Caja -> Cara, Cajun
mate-file-manager-image-converter.x86_64: W: spelling-error %description -l
en_US resize -> reside, re size, re-size
mate-file-manager-image-converter.x86_64: E: incorrect-fsf-address
/usr/share/doc/mate-file-manager-image-converter-1.5.0/COPYING
1 packages and 0 specfiles checked; 1 errors, 2 warnings.

Package Review
==============

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "GPL (v2 or later)", "Unknown or generated". 2 files have unknown
     license. Detailed output of licensecheck in /home/rave/882559-mate-file-
     manager-image-converter/licensecheck.txt
[x]: The spec file handles locales properly.
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 30720 bytes in 3 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
-------
Checking: mate-file-manager-image-converter-1.5.0-1.fc20.x86_64.rpm
mate-file-manager-image-converter.x86_64: W: spelling-error %description -l
en_US Caja -> Cara, Cajun
mate-file-manager-image-converter.x86_64: W: spelling-error %description -l
en_US resize -> reside, re size, re-size
mate-file-manager-image-converter.x86_64: E: incorrect-fsf-address
/usr/share/doc/mate-file-manager-image-converter-1.5.0/COPYING
1 packages and 0 specfiles checked; 1 errors, 2 warnings.

Rpmlint (installed packages)
----------------------------
# rpmlint mate-file-manager-image-converter
mate-file-manager-image-converter.x86_64: W: spelling-error %description -l
en_US Caja -> Cara, Cajun
mate-file-manager-image-converter.x86_64: W: spelling-error %description -l
en_US resize -> reside, re size, re-size
mate-file-manager-image-converter.x86_64: E: incorrect-fsf-address
/usr/share/doc/mate-file-manager-image-converter-1.5.0/COPYING
1 packages and 0 specfiles checked; 1 errors, 2 warnings.
# echo 'rpmlint-done:'

Requires
--------
mate-file-manager-image-converter (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    libatk-1.0.so.0()(64bit)
    libc.so.6()(64bit)
    libcairo.so.2()(64bit)
    libcaja-extension.so.1()(64bit)
    libfontconfig.so.1()(64bit)
    libfreetype.so.6()(64bit)
    libgdk-x11-2.0.so.0()(64bit)
    libgdk_pixbuf-2.0.so.0()(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgtk-x11-2.0.so.0()(64bit)
    libpango-1.0.so.0()(64bit)
    libpangocairo-1.0.so.0()(64bit)
    libpangoft2-1.0.so.0()(64bit)
    rtld(GNU_HASH)

Provides
--------
mate-file-manager-image-converter:
    libcaja-image-converter.so()(64bit)
    mate-file-manager-image-converter
    mate-file-manager-image-converter(x86-64)

Unversioned so-files
--------------------
mate-file-manager-image-converter:
/usr/lib64/caja/extensions-2.0/libcaja-image-converter.so

MD5-sum check
-------------
http://pub.mate-desktop.org/releases/1.5/mate-file-manager-image-converter-1.5.0.tar.xz
:
  CHECKSUM(SHA256) this package     :
2cddca00bf4c9b1fcdc1d665d7d10eea184180ea32ed817613002b3ef3538daf
  CHECKSUM(SHA256) upstream package :
2cddca00bf4c9b1fcdc1d665d7d10eea184180ea32ed817613002b3ef3538daf

Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -v -b 882559 -m fedora-rawhide-x86_64

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bUxiqfZBpR&a=cc_unsubscribe