[Bug 924511] Review Request: gimp-high-pass-filter - High pass filter for the GIMP

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=924511

Hans de Goede <hdegoede at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-review+

--- Comment #2 from Hans de Goede <hdegoede at redhat.com> ---
Hi,

Full review done:

Good:
- rpmlint checks return:
gimp-high-pass-filter.noarch: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 1 warnings.
- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv2+) OK, matches source
  - text not in doc, but given the special nature of the upstream "repo" that
is ok
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- no need for .desktop file

Should fix (but not a blocker):
- Summaries should not begin with "A" or "The", so please drop the "A " from
the Summary

Approved!


Note now that you've been sponsored, it is no longer my "duty" as your sponsor
to review your packages. I did this one as it was very straight-forward. But
for your next package, please don't assign the review to me.

The easiest way to get a review done is to find someone to swap reviews with,
usually this is done by sending a mail to the fedora-devel list with as
subject: "Review swaps" and then you say I've this and this package to be
reviewed, if you can review one for me, I'll review one of your packages (or
some such in your own words).

An added advantages in doing review swaps is that it keeps things fair, you
will end up doing approx. as much reviews as that others are doing reviews for
you.

Regards,

Hans

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZnzMftYpbZ&a=cc_unsubscribe