[Bug 928061] Review Request: nagstamon - Nagios status monitor for desktop

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=928061

--- Comment #6 from Antonio Trande <anto.trande at gmail.com> ---
(In reply to comment #5)
> I have update spec file and SRPM:
> 
> Spec URL: http://jaur.su/nagstamon.spec
> SRPM URL: http://jaur.su/nagstamon-0.9.9-1.fc18.src.rpm

- "Every time you make changes, that is, whenever you increment the E-V-R of a
package, add a changelog entry. This is important not only to have an idea
about the history of a package, but also to enable users, fellow packages, and
QA people to easily spot the changes that you make."
http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs

I consider this new src rpm as release 2 (0.9.9-2). Please, update the
changelog.


> 'Nagstamon/BeautifulSoup.py' file is released with BSD (3 clause) licensing >that must be listed in License tag.

- We must fix this my error: BeautifulSoup.py is a bundled python file, already
maintained in 'python-BeautifulSoup' package. It can't be in nagstamon, too
(http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries). 
Upstream already seems consider this circumstance as you can see in line #17 of
Nagstamon/Server/Generic.py file in the source so I think you may erase
BeautifulSoup.py file in %prep section
(http://fedoraproject.org/wiki/Packaging:Treatment_Of_Bundled_Libraries#Packages_with_Bundled_Libraries),
add python-BeautifulSoup as Requires entry leaving a short comment that
explains the reason and a link to 

http://sourceforge.net/p/nagstamon/bugs/44/

- Why do you use a wildcard ?

>%{_datadir}/applications/*%{name}.desktop

- Please, remember to update the changelog. You should already be at third
release ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VEKT0E3Ywd&a=cc_unsubscribe