[Bug 958881] Review Request: ibus-cangjie - IBus engine to input Cangjie and Quick

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958881

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |
              Flags|                            |fedora-review+

--- Comment #5 from Parag AN(पराग) <panemade at gmail.com> ---
1) I don't think you need to add any comments for desktop file installation
like you added
"# Upstream doesn't validate their desktop files"
This is a standard packaging policy to install desktop files.

2) Autotools stuff just installs generated desktop file into path
/usr/share/applications. I have not seen yet any project using either
desktop-file-validate or some way to validate desktop file before getting
installed.


3) New updated SRPM looks good.

One more thing I want to suggest is to use following way for make install line
as this will preserve the timestamps of files from upstream tarball.

make install DESTDIR=%{buildroot} INSTALL="install -p"

APPROVED this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lfGzeSHnLf&a=cc_unsubscribe