[Bug 962236] Review Request: f1lt - Unofficial Formula 1 live timing application

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=962236

David Tardon <dtardon at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(anto.trande at gmail
                   |                            |.com)

--- Comment #1 from David Tardon <dtardon at redhat.com> ---
Problems:

1. Missing license headers in the following source files:
    src/core/colorsmanager.cpp
    src/main_gui/eventstatuswidget.cpp
    src/player/ltfilesloader.cpp
    src/player/ltfilesloader.h

2. You must use %{?dist}, not %{dist}. It might not be defined.

3. You need to add dependencies for gtk-update-icon-cache.

Requires(post): gtk2
Requires(postun): gtk2

is the right form, I think.

4. rpmlint found several minor issues: a typo, alternative spelling,
   etc. I will not block the package on these, though.
 Checking: f1lt-2.0.2-1.fc18.x86_64.rpm
 f1lt.x86_64: W: spelling-error %description -l en_US analyse -> analyses,
analy st, analyze
 f1lt.x86_64: W: spelling-error %description -l en_US avaialable -> available,
v ariable
 f1lt.x86_64: E: description-line-too-long C    differences between lap and
sect or times, drawing lap, position and gap charts.
 f1lt.x86_64: W: no-manual-page-for-binary f1lt
 1 packages and 0 specfiles checked; 1 errors, 3 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Eb2W9QfOHe&a=cc_unsubscribe