[Bug 952355] Review Request: hovercraft - Makes impress.js presentations from reStructuredText

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=952355

--- Comment #2 from Patrick Uiterwijk <puiterwijk at gmail.com> ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
NO, See below - License CC0/BSD
NO - License field in spec matches
NO, See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream sha256sum:
This package: c21eb09e6e0e5b8fd34275fda08fdd30e52dcf09b22b2ab3293a16287fd212c6
Upstream package:
c21eb09e6e0e5b8fd34275fda08fdd30e52dcf09b22b2ab3293a16287fd212c6


OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good. 
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 
OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
OK, See below - No rpmlint output. 
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should function as described. 
OK - Should have dist tag 
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin

Rpmlint output:
Checking: hovercraft-1.1-1.fc20.noarch.rpm
hovercraft.noarch: W: spelling-error Summary(en_US) reStructuredText ->
restructured Text, restructured-text, restructure
hovercraft.noarch: W: spelling-error %description -l en_US reStructuredText ->
restructured Text, restructured-text, restructure
hovercraft.noarch: W: spelling-error %description -l en_US repositioning -> re
positioning, re-positioning, positioning
hovercraft.noarch: W: dangling-symlink
/usr/lib/python3.3/site-packages/hovercraft/templates/simple/js/impress.js
/usr/share/impressjs/impress.js
hovercraft.noarch: W: dangling-symlink
/usr/lib/python3.3/site-packages/hovercraft/templates/default/js/impress.js
/usr/share/impressjs/impress.js
hovercraft.noarch: W: no-manual-page-for-binary hovercraft
1 packages and 0 specfiles checked; 0 errors, 6 warnings.

The dangling symlinks are bogus: after installation they work.
Spelling errors can be neglected in this case.


Issues: 
1. This package contains reST.xsl, which is licensed BSD. Maybe add this as
well to the spec file? 

2. The package does not contain a COPYING file. Please ask upstream to include
it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lidCkowMIX&a=cc_unsubscribe