[Bug 1023714] Review Request: lpf-skype: Skype internet phone client package bootstrap
bugzilla at redhat.com
bugzilla at redhat.com
Mon Nov 4 09:24:22 UTC 2013
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
--- Comment #14 from Simone Caronni <negativo17 at gmail.com> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Package does not contain duplicates in %files.
Note: warning: File listed twice: /var/lib/lpf/packages/skype/state
See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /var/lib/lpf/packages, /usr/share/lpf,
/var/lib/lpf, /usr/share/lpf/packages
[-]: Package must own all directories that it creates.
Note: Directories without known owners: /var/lib/lpf,
/var/lib/lpf/packages, /usr/share/lpf, /usr/share/lpf/packages
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[!]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[!]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed files.
[x]: Spec use %global instead of %define unless justified.
Note: %define requiring justification: %define target_pkg %(t=%{name};
echo ${t#lpf-})
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
===== EXTRA items =====
Generic:
[!]: Spec file according to URL is the same as in SRPM.
Note: Spec file as given by url is not the same as in SRPM (see attached
diff).
See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
Rpmlint
-------
Checking: lpf-skype-4.2.0.11-2.fc21.noarch.rpm
lpf-skype-4.2.0.11-2.fc21.src.rpm
lpf-skype.noarch: W: spelling-error %description -l en_US redistributable ->
redistribute, redistribution, attributable
lpf-skype.noarch: W: invalid-url URL:
http://leamas.fedorapeople.org/skype/4.2.0.11/skype.spec HTTP Error 404: Not
Found
lpf-skype.noarch: W: non-standard-uid /var/lib/lpf/packages/skype/state
pkg-build
lpf-skype.noarch: W: non-standard-gid /var/lib/lpf/packages/skype/state
pkg-build
lpf-skype.noarch: W: non-standard-uid /var/lib/lpf/packages/skype pkg-build
lpf-skype.noarch: W: non-standard-gid /var/lib/lpf/packages/skype pkg-build
lpf-skype.noarch: E: non-standard-dir-perm /var/lib/lpf/packages/skype 0775L
0 packages and 0 specfiles checked; 1 errors, 6 warnings.
Rpmlint (installed packages)
----------------------------
# rpmlint lpf-skype
lpf-skype.noarch: W: spelling-error %description -l en_US redistributable ->
redistribute, redistribution, attributable
lpf-skype.noarch: W: invalid-url URL:
http://leamas.fedorapeople.org/skype/4.2.0.11/skype.spec HTTP Error 404: Not
Found
lpf-skype.noarch: W: non-standard-uid /var/lib/lpf/packages/skype/state
pkg-build
lpf-skype.noarch: W: non-standard-gid /var/lib/lpf/packages/skype/state
pkg-build
lpf-skype.noarch: W: non-standard-uid /var/lib/lpf/packages/skype pkg-build
lpf-skype.noarch: W: non-standard-gid /var/lib/lpf/packages/skype pkg-build
lpf-skype.noarch: E: non-standard-dir-perm /var/lib/lpf/packages/skype 0775L
1 packages and 0 specfiles checked; 1 errors, 6 warnings.
# echo 'rpmlint-done:'
Diff spec file in url and in SRPM
---------------------------------
--- /home/slaanesh/Documents/fedora/1023714-lpf-skype/srpm/lpf-skype.spec
2013-11-04 10:13:03.342996378 +0100
+++
/home/slaanesh/Documents/fedora/1023714-lpf-skype/srpm-unpacked/lpf-skype.spec
2013-11-01 12:16:04.000000000 +0100
@@ -8,5 +8,5 @@
License: MIT
-URL: https://github.com/leamas/lpf
+URL: http://leamas.fedorapeople.org/skype/4.2.0.11/skype.spec
Group: Development/Tools
BuildArch: noarch
@@ -26,4 +26,5 @@
%prep
%setup -cT
+cp %{SOURCE1} README
@@ -35,5 +36,4 @@
/usr/share/lpf/scripts/lpf-setup-pkg %{buildroot} %{SOURCE0}
desktop-file-validate %{buildroot}%{_datadir}/applications/%{name}.desktop
-cp %{SOURCE1} README
@@ -55,8 +55,6 @@
%changelog
* Fri Nov 1 2013 Alec Leamas <leamas at nowhere.net> - 4.2.0.11-2
-- Adding README.
-- Setting upstream to lpf's.
+- Adding README
- Fix typo.
-- Fix silly README error.
* Sun May 05 2013 Alec Leamas <leamas at nowhere.net> - 4.2.0.11-1
Requires
--------
lpf-skype (rpmlib, GLIBC filtered):
/bin/sh
lpf
Provides
--------
lpf-skype:
application()
application(lpf-skype.desktop)
lpf-skype
Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 -b
1023714
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, SugarActivity, Perl, R, PHP, Ruby
Disabled flags: EPEL5, EXARCH, DISTTAG
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
More information about the package-review
mailing list