[Bug 1026337] Review Request:=?UTF-8?Q?=20nfs=2Dganesha=20=E2=80=94=20a=20user=2Dmode=20file=20server=20for=20NFS=20?=(v3, 4.0, 4.1 pNFS)

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1026337



--- Comment #16 from Kaleb KEITHLEY <kkeithle at redhat.com> ---
> Build issue aside, I find it hard to justify how including this library 
> doesn't violate https://fedoraproject.org
> /wiki/Packaging:No_Bundled_Libraries. You said that "it'll be split out when > ready", but actually is seems to be
> a totally separate project. I'd approve the package as is, otherwise.

Well, then we need an exception I guess. A) It's not really bundled, or I don't
understand your definition of bundled. It's a static lib used during the build,
not installed or even in the RPM, B) Upstream isn't ready to package it
separately because they haven't settled on the final APIs and at the present
time they are the only consumer of it. Its git repo is, at present, still a
part of the nfs-ganesha project on github.  And C) if the license was
incompatible I could definitely understand it, but since it's BSD then I don't
see the license as an issue.

> nfs-ganesha.src:62: W: rpm-buildroot-usage %prep %cmake -DCMAKE_BUILD_TYPE=Maintainer -DBUILD_CONFIG=everything -DCMAKE_INSTALL_PREFIX=%{buildroot}/usr ./src
> Yeah, %cmake step should be moved to %build.
>
> [!]: Package must own all directories that it creates.
>     Note: Directories without known owners: /usr/share/doc/nfs-ganesha-2.0.0
> Directory ownership is missing.

Not sure what the fix is for this. I made a WAG.

> Rpmlint (installed packages)
> ----------------------------
> # rpmlint nfs-ganesha nfs-ganesha-docs
> nfs-ganesha.x86_64: E: explicit-lib-dependency krb5-libs
> 
> Automatic requires should suffice. I get:
>
> libgssapi_krb5.so.2()(64bit)
> libgssapi_krb5.so.2(gssapi_krb5_2_MIT)(64bit)
> libk5crypto.so.3()(64bit)
> libkrb5.so.3()(64bit)
> libkrb5.so.3(krb5_3_MIT)(64bit)
> 
> Isn't this enough?
> 
> Requires
> --------
> nfs-ganesha (rpmlib, GLIBC filtered):
>    ...
>    xfsprogs
>
> Why are xfsprogs required?

new files at 

Spec URL: http://kkeithle.fedorapeople.org/update-6/nfs-ganesha.spec
SRPM URL:
http://kkeithle.fedorapeople.org/update-6/nfs-ganesha-2.0.0-0.rc3.fc19.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component