[Bug 1026764] Review Request: uhttpmock - HTTP web service mocking library

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1026764



--- Comment #3 from Philip Withnall <bugzilla at tecnocode.co.uk> ---
Updated spec file:
http://people.collabora.co.uk/~pwith/packaging/uhttpmock.spec
Updated SRPM URL:
http://people.collabora.co.uk/~pwith/packaging/uhttpmock-0.2.0-1.fc19.src.rpm
Latest Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6143116

(In reply to Christopher Meng from comment #2)
> Like ur first package, please use %global instead of %define.

Fixed.

> 1. Remove obsoleted lines for EL5 only:
> BuildRoot
> %clean
> %defattr(-,root,root,-)

Fixed. I got them from
https://fedoraproject.org/wiki/How_to_create_an_RPM_package#SPEC_templates_and_examples;
would it be wise to update that page?

> 2. URL is https://gitorious.org/uhttpmock/.

Fixed.

> 3. $RPM_BUILD_ROOT/%{_libdir} --> $RPM_BUILD_ROOT%{_libdir}

Fixed.

> 4. Missing %{?_isa} macro of Requires in -devel subpackage, which actually
> should be:

Fixed.

> 5. Some fields in -devel subpackage is not good.

Fixed.

> 6. %{_includedir}/libuhttpmock-0.0
> 
> Your package name is uhttpmock, have you made a decision of which name is
> better, uhttpmock or libuhttpmock?

uhttpmock is the project name, libuhttpmock is a library which is part of the
project. I full expect that a ‘uhttpmock’ program will be added to the project
in future, hence I carefully chose to use ‘uhttpmock’ and ‘libuhttpmock’ in
appropriate places.

> And 0.0 stands for what?

The API version of libuhttpmock, so that API-incompatible versions can be
parallel installed. I’ve updated the spec file to move this into a %global.

> 7. Summary:        Mocking test utility for HTTP and HTTPS web APIs
> 
> Isn't it a library?

See above.

> From pc file: HTTP web service mocking library
> 
> From homepage: A HTTP web service mocking library for GNOME

I’ve unified these.

Thanks for your help!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component