[Bug 1024127] Review Request: lttv - Linux Trace Toolkit Viewer

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1024127



--- Comment #13 from Suchakra <suchakra at gmail.com> ---
Hi,

> Do you understand what the changelog is supposed to contain?  Compare to
> other packages with 'rpm -q --changelog <pkgname>'.

Thanks for clarifying. I have changed this appropriately.

> - You need to filter the provides of the plugins - see
> https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering

Did that too. I hope its correct.

> - I've sponsored you.

Thanks :)

> Minor -  
> 
> - you really don't need lttv-devel to require glibc-devel, that's generally
> assumed.
> - Add --disable-silent-rules to %configure - it's good to verify the
> compiler arguments.

I took care of both of them too.

Updated the new spec and SRPM based on Comment 12 :

Spec URL: http://suchakra.fedorapeople.org/packages/lttv.spec
SRPM URL: http://suchakra.fedorapeople.org/packages/lttv-1.5-3.fc19.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component