[Bug 1022283] Review Request: gnulib - GNU Portability Library

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1022283



--- Comment #46 from Michael Schwendt <bugs.michael at gmx.net> ---
Just a comment on this:

> SRPM URL: http://ojuba.org/oji/SRPMS/gnulib-0.1.git20131112-1.oji.fc19.src.rpm

It looks very unusual to have "git20131112" as part of the %{version}. Since
this is a snapshot from git, the following applies:

  https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages

And if the internal version really is 0.1, you need to decide on whether it's a
pre-release or post-release snapshot:

 
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages
 
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Post-Release_packages

With 0.1.git2013112 in %version, you could not upgrade to 0.1 final, for
example:

  $ rpmdev-vercmp 0.1.git20131112 0.1
  0.1.git20131112 > 0.1

With the versioning guidelines applied, the package will look like:

  gnulib-0.1-0.X.20131112git.fc19.src.rpm

with X being the release number you would increase for ordinary packaging
changes (including rebuilds or newer/older snapshots).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component