[Bug 1034347] Review Request: libvirt-python - python binding for libvirt library

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1034347



--- Comment #2 from Cole Robinson <crobinso at redhat.com> ---
Some bits flagged by fedora-review:

libvirt-python.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/libvirtmod_qemu.so
libvirtmod_qemu.so()(64bit)
libvirt-python.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/libvirtmod_lxc.so libvirtmod_lxc.so()(64bit)
libvirt-python.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/libvirtmod.so libvirtmod.so()(64bit)

The %filter macros handle this, it's just not the 'newest' way. So that's fine.

libvirt-python.x86_64: E: non-executable-script
/usr/lib64/python2.7/site-packages/libvirt_lxc.py 0644L /usr/bin/python
libvirt-python.x86_64: E: non-executable-script
/usr/lib64/python2.7/site-packages/libvirt_qemu.py 0644L /usr/bin/python
libvirt-python.x86_64: E: non-executable-script
/usr/lib64/python2.7/site-packages/libvirt.py 0644L /usr/bin/python

Indeed /usr/bin/python should be dropped from these files upstream, but not a
blocker really.

Manual review looks fine. There's some stuff that could be dropped if the spec
was only targeting modern Fedora, but given how libvirt tracks specs upstream
and still targets RHEL5 it makes sense why devs would want to keep those bits.

So ACK. When the official release is done I'll re-review and set the correct
flags.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component