[Bug 1035425] Review Request: gfbgraph - GLib/GObject wrapper for the Facebook Graph API

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1035425



--- Comment #2 from Debarshi Ray <debarshir at redhat.com> ---
(In reply to Christopher Meng from comment #1)

Spec: http://rishi.fedorapeople.org/gfbgraph.spec
SRPM: http://rishi.fedorapeople.org/gfbgraph-0.2.1-2.fc20.src.rpm

> 1. RPM can handle pkg-config well now.
> 
> Please remove Requires:       pkgconfig in -devel.

Done.

> 2. %define api 0.2 --> %global api 0.2

Done.

> 3. %dir %{_includedir}/%{name}-%{api}
> %{_includedir}/%{name}-%{api}/%{name}
> 
> Oh?
> 
> Why not just
> 
> %{_includedir}/%{name}-%{api}

Mostly a matter of style or habit to make it obvious (to myself?) that it is a
directory and not a file.

> 4. Since you've defined an api macro, according to GNOME software release
> habit, is it O to define version tag like this?
> 
> Version:        %{api}.1

Done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component