[Bug 1014336] Review Request: python-halite - Web GUI for SaltStack

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1014336



--- Comment #8 from Mario Blättermann <mario.blaettermann at gmail.com> ---
(In reply to Erik Johnson from comment #6)
> (In reply to Mario Blättermann from comment #5)
> > Last but not least, please get rid of the spec parts which are only needed
> > for EPEl 5 once your package will be imported into EPEL >= 6 and Fedora:
> > 
> > * BuildRoot definition
> > * The header which defines python_sitelib
> > * Initial cleaning of buildroot in %install
> > * The %clean section
> > * %defattr line in %files
> 
> I'm sorry, but I had trouble understanding what you meant here. Do you mean
> that these parts are not needed anymore? Or that they should be enclosed
> within %if blocks like so:
> 
> %if ! (0%{?rhel} >= 6 || 0%{?fedora} > 12)
> BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> %endif

Indeed, all these things are only needed for EPEL 5. For EPEL >= 6 and all
currently supported Fedora versions, they are useless, because rpm defaults to
them anyway. But this is a post-review task. Well, I know about a lot of
packages which are in Fedora for a long time and entrain all this useless
things also in newer branches and even in Rawhide. Without them, the spec file
would become much better readable and understandable for unexperienced
packagers. If you mean it is too much work to maintain different spec files for
different Git branches, you could set conditions, but this also doesn't make
sense. Keep in mind, due to the age of EPEL5, we still need such special things
therefore, but after EPEL5 becomes EOL in 2017, they become obsolete generally.
Be future-proof and follow my proposal.

BTW, if you don't plan to maintain your package for EPEL 5 at all, you can drop
the mentioned parts anyway.

-- 
You are receiving this mail because:
You are on the CC list for the bug.