[Bug 1019428] Review Request: python-alchimia - a new and (perhaps) interesting sqlalchemy+twisted integration

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1019428

Mario Blättermann <mario.blaettermann at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mario.blaettermann at gmail.co
                   |                            |m



--- Comment #1 from Mario Blättermann <mario.blaettermann at gmail.com> ---
Your package bundles a prebuilt egg, please remove it before building the
package:
rm -rf %{srcname}.egg-info
See http://fedoraproject.org/wiki/Packaging:Python_Eggs#Upstream_Eggs.

The summary is not really informative. Use that one from your review request:
"New and (perhaps) interesting sqlalchemy+twisted integration"


Buildarch: noarch
It is actually "BuildArch: noarch". Don't know if it would work anyway, but my
text editor marks it as a typo.


%install
%{__rm} -rf %{buildroot}
...
%clean
%{__rm} -rf %{buildroot}
...
%defattr(-, root, root, 0755)

These parts are for EPEL5 only. If you really point to this release, you have
to add a spec file header which defines %{python_sitelib} and a BuildRoot
definition. Otherwise, remove them.


License:    The MIT License (MIT)
"License: MIT" is sufficient here.


I'm missing some %doc files:
AUTHORS
ChangeLog
CONTRIBUTING.rst
LICENSE

-- 
You are receiving this mail because:
You are on the CC list for the bug.