[Bug 1018859] Review Request: perl-Term-Clui - Term::Clui Perl module

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1018859



--- Comment #3 from Kostas Georgiou <k.georgiou at atreides.org.uk> ---
Thanks for the review, here are the new files and the changes.

Spec URL: http://georgiou.fedorapeople.org/perl-Term-Clui.spec
SRPM URL: http://georgiou.fedorapeople.org/perl-Term-Clui-1.68-2.fc21.src.rpm

> FIX: The summary is not descriptive. See README or Clui.pm for better text.
DONE

> TODO: Remove the BuildRoot definition and cleaning in the %install section and
> remove the whole %clean section. They are not needed for Fedora.
DONE, I can always add them back if we need the package in epel-5

> TODO: You can replace `%{__perl}' macro with plain `perl' command.
DONE

> TODO: You can replace PERL_INSTALL_ROOT argument with standard DESTDIR argument
> in the %install section.
This doesn't seem to work:
  make pure_install
DISTDIR=/builddir/build/BUILDROOT/perl-Term-Clui-1.68-2.fc21.x86_64
  ERROR: Can't create '/usr/share/man/man3'
  Do not have write permissions on '/usr/share/man/man3'

> TODO: You can remove deleting empty directories in the %install section.
> ExtUtils::MakeMaker does not create empty directories anymore.
DONE

> FIX: Remove %defattr macro from %files section. This is not needed anymore
> (since rpm-4.4).
DONE

> TODO: You could package the `example' subdirectory as a documentation.
DONE

> FIX: Build-require `perl(Exporter)' (Clui.pm:13).
> TODO: Build-require `perl(strict)' (Clui.pm:20).
> TODO: Build-require `perl(warnings)' (Clui.pm:20).
> TODO: Run-require `perl(strict)' (Clui.pm:20).
> TODO: Run-require `perl(warnings)' (Clui.pm:20).
DONE

-- 
You are receiving this mail because:
You are on the CC list for the bug.