[Bug 1019403] Review Request: gst-editing-services - Gstreamer editing services

bugzilla at redhat.com bugzilla at redhat.com
Fri Oct 18 06:46:55 UTC 2013


https://bugzilla.redhat.com/show_bug.cgi?id=1019403

Christopher Meng <cickumqt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |cickumqt at gmail.com
           Assignee|nobody at fedoraproject.org    |cickumqt at gmail.com
              Flags|                            |fedora-review?



--- Comment #1 from Christopher Meng <cickumqt at gmail.com> ---
First from SPEC:

1. TOP line is empty, you should remove it.

2. When can we switch to 

http://cgit.freedesktop.org/gstreamer/gst-editing-services/snapshot/gst-editing-services-1.1.90.tar.gz

?

3. Explicit arch requires(isa macro missing):

Requires:          %{name}%{?_isa} = %{version}-%{release}

4. I would describe devel package as:

%description       devel
This package contains libraries and header files for
developing applications that use %{name}.

5. autoreconf -if

-->

autoreconf -fiv (v for verbose)

6. rpm -E %configure shows that --prefix=/usr is included, do we need it again?

7. Cleanup rm -rf $RPM_BUILD_ROOT in %install

8. Hint:

find $RPM_BUILD_ROOT -name '*.la' | xargs rm -f

-->

find $RPM_BUILD_ROOT -name '*.la' -delete

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the package-review mailing list