[Bug 979793] Review Request: php-symfony2-Debug - Symfony2 Debug Component

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=979793

Remi Collet <fedora at famillecollet.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?



--- Comment #3 from Remi Collet <fedora at famillecollet.com> ---
Koji scratch build
http://koji.fedoraproject.org/koji/taskinfo?taskID=6080475

Issues:
=======
[!]: Sources used to build the package match the upstream source, as provided
in
  the spec URL.
  Note: Upstream MD5sum check error, diff is in
  /home/extras/SPECS/review/979793-php-symfony2-Debug/diff.txt
  See: http://fedoraproject.org/wiki/Packaging/SourceURL
    => minor diff in the package.xml which have 
    obviously be regenerated, not an issue for the review
[~]: Package is named according to the Package Naming Guidelines.
    New Guildelines recommend the use of lowercase names.
    As all the symfony2 stack use CamelCase, I thinks
    this could be ignored.
[!]: Package consistently uses macros (instead of hard-coded directory names).
    => only a small comment
    symfony_{min,max}_ver could be ambiguous, as according to various
    composer.json, you have not a single minimal version, some
    could require 2.0, 2.1, 2.2 or 2.3. So a per component version
    seems clearer.
[~]: Package is named according to the Package Naming Guidelines.
    New Guildelines recommend the use of lowercase names.
    As all the symfony2 stack use CamelCase, I thinks
    this could be ignored.
[!]: Requires correct, justified where necessary.
    php-common => php(language)
[!]: Latest version is packaged.
    2.3.6 available

-- 
You are receiving this mail because:
You are on the CC list for the bug.