[Bug 892335] Review Request: AudioCuesheetEditor - Audio Cuesheet Editor

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=892335



--- Comment #34 from Christopher Meng <cickumqt at gmail.com> ---
My point:

1. From your desktop entry I can see icon is located at:

Icon=/usr/lib/%{name}/resources/icons/application-x-cue-128.png

In common we put icons under /usr/share/pixmaps.

I also think that all data files should be installed to %{_datadir}/%{name} but
not /usr/lib/%{name}

2. Mix using  %{buildroot} and ${RPM_BUILD_ROOT}, you should only use one of
them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.