[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1021733



--- Comment #6 from Björn "besser82" Esser <bjoern.esser at gmail.com> ---
(In reply to Christopher Meng from comment #5)
> (In reply to Björn "besser82" Esser from comment #4)
> > [!]: License file installed when any subpackage combination is installed.
> > 
> >      ---> License is missing in -doc. The -doc sub-pkg should have
> >           `%doc changelog LICENSE README build/sphinx/html` (without that
> >           '/*' suffixed) instead of `%doc build/sphinx/html/*`.  So it
> >           will pick-up all docs && carry a html-subdir.
> 
> I'm sorry, but I don't agree.
> I think doc package should only contains docs, but no need to ship changelog
> LICENSE README anymore. Besides I think keeping /* will let users enter the
> dir and see docs immediately but not enter a html folder again.

Ain't changelog, license, readme docs, are they?  I usually _strongly
recommend_ to add them to -doc.  And for that reason finding them between a
kazillion other files is extremely hard, I recommend keeping html-doc in a
html-subdir...


> > [!]: %check is present and all tests pass.
> > 
> >      ---> there is a tests-subdir in tarball.  You should BR:
> >           python-nose, python3-nose and run the corresponding
> >           `nosetests` within %check.
> 
> Because tests will fail to test.
> 
> 1. Simply use
> 
> nosetests-%{python_version}
> 
> Failed because ImportError: No module named secretstorage
> 
> 2. Then I did a tricks:
> 
> PYTHONPATH=%{buildroot}%{python_sitelib} nosetests-%{python_version}
> 
> This time real failures are coming:
> 
> ----------------------------------------------------------------------
> Ran 7 tests in 0.893s
> 
> FAILED (errors=5)
> error: Bad exit status from /var/tmp/rpm-tmp.NGiSNR (%check)
> 
> ----------------------------------------------------------------------
> 
> Also my computer's keyring unlock window bumped out and asked my password.
> 
> So I didn't add tests.

Did you ask upstream about that?  Failing test are usually _really_ bad.  :(


> I will listen to your new opinions and then upload a new version.

There you go.  :D

-- 
You are receiving this mail because:
You are on the CC list for the bug.