[Bug 1024993] Review Request: lin_guider - Astronomical autoguiding program

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1024993



--- Comment #7 from Antonio Trande <anto.trande at gmail.com> ---
(In reply to Lukash James from comment #6)
> I have a question. Should I add new entries in %changelog if I fixed
> anything?

- You may update and replace the existing data line since your package is not
built yet.
See
http://fedoraproject.org/wiki/Packaging:Guidelines#Multiple_Changelog_Entries_per_Release

- Move the %check section after %install
  Was 'desktop-file-install' line already in your first .spec file ? If yes,
desktop-file-validate is useless at this point. :P

'desktop-file-install' already validates the .desktop files automatically. 

- Move the line

%{!?_pkgdocdir: %global _pkgdocdir %{_docdir}/%{name}-%{version}}

at the top.

-- 
You are receiving this mail because:
You are on the CC list for the bug.