[Bug 927374] Review Request: rubygem-rugged - Ruby binding to the libgit2 linkable library

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=927374



--- Comment #15 from Vít Ondruch <vondruch at redhat.com> ---
* Hidden files
  - It looks that rugged is not shipping the hidden files you are removing
    anymore. I suggest to drop that line.

* Use rubygem(minitest) only
  - There is anywhere any notion, that the test suite is designed for
    rubygem(test-unit). Please drop the BR and go forward just with
    rubygem(minitest) and testrb

* Omitted dot files
  - It seems that upstream .gemspec has a bug in line [1]. There are not
    included dot files in resulting .gem, therefore there are missing folders
    such as [2] and hence several test cases fail.
  - Even though the upstream sources differ already, the bug in .gemspec is
    still there. Would you mind to report this issue upstream?
  - Please add the dot directories as additional source to fix the test suite.

* Missing global git config
  - There is one more failing test:

    ConfigTest#test_read_global_config_file [/builddir/build/BUILD/
       
rugged-0.19.0/usr/share/gems/gems/rugged-0.19.0/test/config_test.rb:19]:
    Failed assertion, no message given.

  - This can be fixed by setting global git configuration, such as:

    $ git config --global user.name John Doe    

  - Not sure if that should not be done by test suite itself.

* Add BR: /usr/bin/git
  - This fixes plenty of test cases, it seems (but please, double check when
    you have the missing dot files available).

* Filter the .so file provides
  - Please add %{?rubygems_default_filter} macro prior description. Although
    this macro is not yet documented in Ruby packaging guidelines, it removes
    the automatically generated rugged.so provide, which is useless for Ruby
    package.


[1] https://github.com/libgit2/rugged/blob/development/rugged.gemspec#L16
[2] https://github.com/libgit2/rugged/tree/v0.19.0/test/fixtures/diff/.gitted

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wWaBoAwuHx&a=cc_unsubscribe