[Bug 991294] Review Request: python-appdirs - A small Python module for determining appropriate platform-specific dirs

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=991294



--- Comment #5 from Christopher Meng <cickumqt at gmail.com> ---
READ IT CAREFULLY.

1. python-appdirs.src:5: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab:
line 4)

2. python-appdirs.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/appdirs.py 0644L /usr/bin/env


Requires
--------
python-appdirs (rpmlib, GLIBC filtered):
    /usr/bin/env
    python(abi)


3. Just got new revised guidelines from FPC, all python2.x stuffs should be
renamed to python2 related.

So:
- %{__python} --> %{__python2}
- %{python_sitelib} --> %{python2_sitelib}

4. %{__python} %{_builddir}/%{pkgname}-%{commit}/test/test.py

Just use %{__python} test/test.py is enough.

5. MUSTN'T leave macro in %changelog section:

* Fri Aug 2 2013 Marcelo Barbosa <mr.marcelo.barbosa at gmail.com> - 1.2.0-2
- Remove %clean
- Remove egg-dir in %prep

Please double %% them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3z3zSFvdal&a=cc_unsubscribe