[Bug 1009754] Review Request: perl-Term-RawInput - Replacement for <STDIN> in perl scripts

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1009754

Ralf Corsepius <rc040203 at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203 at freenet.de



--- Comment #1 from Ralf Corsepius <rc040203 at freenet.de> ---
Similar issues as with your perl-Term-Menu package.

* Fails to build in mock due to missing BR:s:
Please add: 
BuildRequires:  perl(Term::ReadKey)
BuildRequires:  perl(IO::Handle)

* This package applies ExtUtils::AutoInstall.
As rpms are supposed to use preinstalled perl-dists and not to autoinstall
missing dists, using ExtUtils::AutoInstall in rpm-specs is not allowed.

Please add --skipdeps to your "perl Makefile.PL". I am ususually using this in
my specs:
...
# --skipdeps causes ExtUtils::AutoInstall not to try auto-installing
%{__perl} Makefile.PL INSTALLDIRS=vendor --skipdeps
...

* The License: field needs to be
License:        GPL+ or Artistic

* Unless you intent to support EPEL5,
Group: ...
...
BuildRoot:      %{_tmppath}/%{name}-%{version}-build
...
rm -rf $RPM_BUILD_ROOT
...
%defattr(-,root,root,-)
...

can all be removed.

* Macro usage is inconsistent:
%__perl and %{__perl} are both being used.
Please only use one of these (I recommend using %{__perl})

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uJxlvyNNRg&a=cc_unsubscribe