[Bug 1084865] Review Request: python-bloom - Bloom is a release automation tool for catkin packages

bugzilla at redhat.com bugzilla at redhat.com
Tue Apr 8 04:00:30 UTC 2014


https://bugzilla.redhat.com/show_bug.cgi?id=1084865



--- Comment #4 from Scott K Logan <logans at cottsay.net> ---
Great points, Rich.

Github URL: done
Package HTML with docs: done
Package man page: done

As for the distribute error, it looks like a legacy python dependency in the
setup.py. I've filed upstream [1] to have the dependency either fixed or
removed. For now, I patched the dependency to be on setuptools instead of
distribute, but I'm fairly certain it doesn't need to be there at all (that is,
only needs to be a build dep, not an install dep).

The reason that I never hit this in my testing is because I used pip to install
bloom at one point or another, which installed distribute. Good catch.

Spec URL: http://cottsay.fedorapeople.org/python-bloom/python-bloom.spec
SRPM URL:
http://cottsay.fedorapeople.org/python-bloom/python-bloom-0.5.2-1.fc20.src.rpm

Koji scratch builds:
F19: http://koji.fedoraproject.org/koji/taskinfo?taskID=6716996
F20: http://koji.fedoraproject.org/koji/taskinfo?taskID=6716994

rpmlint output:
python-bloom.src: W: spelling-error %description -l en_US buildpackage -> build
package, build-package, prepackage
python-bloom.src: W: spelling-error %description -l en_US debian's -> Debian's
python-bloom.src: W: spelling-error %description -l en_US src -> arc, sec, sic
python-bloom.noarch: W: spelling-error %description -l en_US buildpackage ->
build package, build-package, prepackage
python-bloom.noarch: W: spelling-error %description -l en_US debian's ->
Debian's
python-bloom.noarch: W: spelling-error %description -l en_US src -> arc, sec,
sic
python-bloom.noarch: W: devel-file-in-non-devel-package
/usr/bin/git-bloom-config
python-bloom.noarch: W: no-manual-page-for-binary git-bloom-generate
python-bloom.noarch: W: no-manual-page-for-binary git-bloom-import-upstream
python-bloom.noarch: W: no-manual-page-for-binary bloom-generate
python-bloom.noarch: W: no-manual-page-for-binary git-bloom-branch
python-bloom.noarch: W: no-manual-page-for-binary git-bloom-release
python-bloom.noarch: W: no-manual-page-for-binary git-bloom-patch
python-bloom.noarch: W: no-manual-page-for-binary bloom-update
python-bloom.noarch: W: no-manual-page-for-binary git-bloom-config
python-bloom.noarch: W: no-manual-page-for-binary bloom-export-upstream
python-bloom.noarch: W: no-manual-page-for-binary bloom-release
2 packages and 1 specfiles checked; 0 errors, 17 warnings.

Thanks,

--scott

[1] https://github.com/ros-infrastructure/bloom/issues/265

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component


More information about the package-review mailing list