[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service

Wed Apr 16 20:47:33 UTC 2014

https://bugzilla.redhat.com/show_bug.cgi?id=1075822

Haïkel Guémar <karlthered at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #25 from Haïkel Guémar <karlthered at gmail.com> ---
Thanks, congratulations for joining the Fedora Packager group :)

I hereby approve this package into Fedora Packages Collection, please file a
scm request and feel free to ping me if you need help.

http://fedoraproject.org/wiki/Package_SCM_admin_requests

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)".
     3 files have unknown license. Detailed output of licensecheck in
     /home/haikel/1075822-openstack-marconi/licensecheck.txt
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /etc/logrotate.d
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
-------
Checking: openstack-marconi-2014.1.b3-1.fc20.noarch.rpm
          openstack-marconi-2014.1.b3-1.fc20.src.rpm
openstack-marconi.noarch: W: spelling-error %description -l en_US multi ->
mulch, mufti
openstack-marconi.noarch: W: non-standard-gid /etc/marconi/logging.conf marconi
openstack-marconi.noarch: E: non-readable /etc/marconi/logging.conf 0640L
openstack-marconi.noarch: W: non-standard-gid /etc/marconi/marconi.conf marconi
openstack-marconi.noarch: E: non-readable /etc/marconi/marconi.conf 0640L
openstack-marconi.noarch: W: non-standard-gid
/etc/logrotate.d/openstack-marconi marconi
openstack-marconi.noarch: W: non-standard-uid /var/log/marconi marconi
openstack-marconi.noarch: W: non-standard-gid /var/log/marconi marconi
openstack-marconi.noarch: E: non-standard-dir-perm /var/log/marconi 0750L
openstack-marconi.noarch: W: no-manual-page-for-binary marconi-server
openstack-marconi.src: W: spelling-error %description -l en_US multi -> mulch,
mufti
2 packages and 0 specfiles checked; 3 errors, 8 warnings.

Rpmlint (installed packages)
----------------------------
# rpmlint openstack-marconi
openstack-marconi.noarch: W: spelling-error %description -l en_US multi ->
mulch, mufti
openstack-marconi.noarch: W: non-standard-gid /etc/marconi/logging.conf marconi
openstack-marconi.noarch: E: non-readable /etc/marconi/logging.conf 0640L
openstack-marconi.noarch: W: non-standard-gid /etc/marconi/marconi.conf marconi
openstack-marconi.noarch: E: non-readable /etc/marconi/marconi.conf 0640L
openstack-marconi.noarch: W: non-standard-gid
/etc/logrotate.d/openstack-marconi marconi
openstack-marconi.noarch: W: non-standard-uid /var/log/marconi marconi
openstack-marconi.noarch: W: non-standard-gid /var/log/marconi marconi
openstack-marconi.noarch: E: non-standard-dir-perm /var/log/marconi 0750L
openstack-marconi.noarch: W: no-manual-page-for-binary marconi-server
1 packages and 0 specfiles checked; 3 errors, 7 warnings.
# echo 'rpmlint-done:'

Requires
--------
openstack-marconi (rpmlib, GLIBC filtered):
    /bin/sh
    /usr/bin/python2
    config(openstack-marconi)
    python(abi)
    python-babel
    python-bson
    python-falcon
    python-iso8601
    python-jsonschema
    python-keystoneclient
    python-memcached
    python-msgpack
    python-netaddr
    python-oslo-config
    python-pymongo
    python-six
    python-sqlalchemy
    python-sqlite3dbm
    python-stevedore
    python-webob
    shadow-utils
    systemd

Provides
--------
openstack-marconi:
    config(openstack-marconi)
    openstack-marconi

Source checksums
----------------
https://launchpad.net/marconi/icehouse/icehouse-3/+download/marconi-2014.1.b3.tar.gz
:
  CHECKSUM(SHA256) this package     :
190c3ecf776b87e7d3efc9b266f581c336841db7724e93098af6590729d0a980
  CHECKSUM(SHA256) upstream package :
190c3ecf776b87e7d3efc9b266f581c336841db7724e93098af6590729d0a980

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component