[Bug 1089634] Review Request: perl-Crypt-SaltedHash - Perl interface to functions that assist in working with salted hashes

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1089634



--- Comment #4 from David Dick <ddick at cpan.org> ---
Hi Petr, all fixed except for removing Digest::SHA as a build-time dependency. 
It gets used in rawhide in t/bug-localize-regex-vars.t as seen below. It's
undetectable as the only place it is referenced is in Crypt::SaltedHash->new
when the algorithm is not specified.

PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-MTest::Harness"
"-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')"
t/*.t
t/01use.t .................... ok
t/02pod.t .................... skipped: Test::Pod 1.14 required
t/03podcoverage.t ............ skipped: Test::Pod::Coverage 1.04 required
t/04Crypt-SaltedHash.t ....... ok
#   Failed test 'validate() lived even through non-match and $1 already set!'
#   at t/bug-localize-regex-vars.t line 19.
#          got: 'Can't locate Digest/SHA.pm in @INC (you may need to install
the Digest::SHA module) (@INC contains:
/builddir/build/BUILD/Crypt-SaltedHash-0.09/blib/lib
/builddir/build/BUILD/Crypt-SaltedHash-0.09/blib/arch /usr/local/lib64/perl5
/usr/local/share/perl5 /usr/lib64/perl5/vendor_perl
/usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at
/usr/share/perl5/vendor_perl/Digest.pm line 41.
# '
#     expected: undef
# Looks like you failed 1 test of 3.
t/bug-localize-regex-vars.t .. 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests 
Test Summary Report
-------------------
t/bug-localize-regex-vars.t (Wstat: 256 Tests: 3 Failed: 1)
  Failed test:  2
  Non-zero exit status: 1
Files=5, Tests=10,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.11 cusr  0.01
csys =  0.16 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component