[Bug 1087734] Review Request: php-horde-imp - A web based webmail system

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1087734



--- Comment #3 from Shawn Iwinski <shawn.iwinski at gmail.com> ---
[!]: Package contains no bundled libraries without FPC exception.

     /usr/share/horde/imp/js/murmurhash3.js = 
         https://github.com/kazuyukitanimura/murmurhash-js

>     /**
>      * JS Implementation of MurmurHash3
>      *
>      * Original version:
>      * https://github.com/kazuyukitanimura/murmurhash-js
>      *
>      * Additions by Michael Slusarz <slusarz at horde.org>

     It appears the original source has additions by horde.  The original
source is MIT and this file still has the MIT license text in it.  If this is
allowed, does that mean MIT should be listed in the license field as well? 
This is probably more of a license question than a bundled library
question/issue.





[!]: Requires correct, justified where necessary.

     Per package.xml, update
         Requires:       php-pear(%{pear_channel}/Horde_Mime) >= 2.0.0
     to
         Requires:       php-pear(%{pear_channel}/Horde_Mime) >= 2.1.0


     Per package.xml, update
         Requires:       php-pear(%{pear_channel}/Horde_Url) >= 2.0.0
     to
         Requires:       php-pear(%{pear_channel}/Horde_Url) >= 2.2.0


     Per package.xml, add
         Requires:       php-pear(%{pear_channel}/Horde_Text_Filter_Csstidy) <
3.0.0


     Update comment
         # Optional and implicitly required:
         #     Horde_Vfs, Horde_History, Horde_Http, Horde_Stream_Filter
     to
         # Optional and implicitly required:
         #     Horde_History, Horde_Http


     Per phpcompatinfo, I do not see "php-ereg" or "php-posix" dependencies.





The HTTP config has "<DirectoryMatch
%{pear_hordedir}/%{pear_name}/(config|lib|locale)>", but the "templates"
directory has the same .htaccess file contents that the listed directories have
so shouldn't it be added in the config as well?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component