[Bug 1120299] Review Request: perl-Inline-Struct - Manipulate C structures directly from Perl

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1120299



--- Comment #6 from Petr Pisar <ppisar at redhat.com> ---
Spec file changes:

--- perl-Inline-Struct.spec.old 2014-07-17 16:25:42.000000000 +0200
+++ perl-Inline-Struct.spec     2014-08-05 14:23:55.000000000 +0200
@@ -13,7 +13,7 @@
 BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.76
 BuildRequires:  perl(Inline)
 BuildRequires:  perl(Inline::C)
-BuildRequires:  perl(Parse::RecDEscent)
+BuildRequires:  perl(Parse::RecDescent)
 BuildRequires:  perl(strict)
 BuildRequires:  perl(vars)
 Requires:       perl(:MODULE_COMPAT_%(eval "$(perl -V:version)"; echo
$version))

> FIX: `perl(Parse::RecDEscent)' build-dependency is not provided by any package.
-BuildRequires:  perl(Parse::RecDEscent)
+BuildRequires:  perl(Parse::RecDescent)
Ok.

All build-time dependencies are declared. Ok.
All tests pass. Ok.

$ rpmlint  perl-Inline-Struct.spec
../SRPMS/perl-Inline-Struct-0.06-1.fc22.src.rpm
../RPMS/noarch/perl-Inline-Struct-0.06-1.fc22.noarch.rpm 
perl-Inline-Struct.src: W: spelling-error %description -l en_US typemaps ->
type maps, type-maps, typecast
perl-Inline-Struct.noarch: W: spelling-error %description -l en_US typemaps ->
type maps, type-maps, typecast
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Inline-Struct-0.06-1.fc22.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Aug  5 14:32
/usr/share/doc/perl-Inline-Struct
-rw-r--r--    1 root    root                     1808 Jun 11  2001
/usr/share/doc/perl-Inline-Struct/README
-rw-r--r--    1 root    root                      619 May  2  2001
/usr/share/doc/perl-Inline-Struct/TODO
-rw-r--r--    1 root    root                     4017 Aug  5 14:32
/usr/share/man/man3/Inline::Struct.3pm.gz
drwxr-xr-x    2 root    root                        0 Aug  5 14:32
/usr/share/perl5/vendor_perl/Inline
drwxr-xr-x    2 root    root                        0 Aug  5 14:32
/usr/share/perl5/vendor_perl/Inline/Struct
-rw-r--r--    1 root    root                    10099 Jun 11  2001
/usr/share/perl5/vendor_perl/Inline/Struct.pm
-rw-r--r--    1 root    root                     5227 May 14  2001
/usr/share/perl5/vendor_perl/Inline/Struct.pod
-rw-r--r--    1 root    root                     4686 Jun 11  2001
/usr/share/perl5/vendor_perl/Inline/Struct/grammar.pm
File permissions and layout are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Inline-Struct-0.06-1.fc22.noarch.rpm
| sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.18.2)
      1 perl(Carp)
      1 perl(Data::Dumper)
      1 perl(Inline)
      1 perl(Inline::Struct::grammar)
      1 perl(strict)
      1 perl(vars)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
FIX: Run-require `perl(Parse::RecDescent)' (Struct.pm:20).

$ rpm -q --provides -p ../RPMS/noarch/perl-Inline-Struct-0.06-1.fc22.noarch.rpm
| sort -f | uniq -c
      1 perl(Inline::Struct) = 0.06
      1 perl(Inline::Struct::grammar) = 0.10
      1 perl-Inline-Struct = 0.06-1.fc22
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Inline-Struct-0.06-1.fc22.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F22
(http://koji.fedoraproject.org/koji/taskinfo?taskID=7243399). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please correct all the `FIX' items, and provides new spec file.
Resolution: NOT approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component