[Bug 1128253] Review Request: gerrymander - A client API and command line tool for gerrit

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1128253



--- Comment #3 from Parag AN(पराग) <panemade at gmail.com> ---
First few things to fix
1) We use %global over %define. Fix this

2) If not defined macro "%{?extra_release}" then we don't even need it. You can
remove this.

3) Group tag is optional but can be kept if building for EPEL

4) Replace python with python2 wherever it applies.

5) Please have correct summary matching to package name

6) use python2 macros wherever applies

7) defattr is not needed 

8) This package is not compiling anything so we don't need
CFLAGS="$RPM_OPT_FLAGS" in %build

9) If upstream provides egginfo in source we need to remove it in %prep and
package built egginfo in %install. You are removing it actually in %install

10) use source url as
Source0: https://github.com/berrange/%{name}/archive/v%{version}.tar.gz

Please provide updated package for further review and check the
https://fedoraproject.org/wiki/Packaging:Python page. This package spec is not
following those guidelines.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component