[Bug 1127879] Review Request: gnudiff

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1127879



--- Comment #8 from Mat Booth <mat.booth at redhat.com> ---
(In reply to Ismael Olea from comment #6)
> (In reply to gil cattaneo from comment #5)
> > there are also unneeded BR:
> > BuildRequires:  java-devel >= 1:1.6.0
> > BuildRequires:  maven-local
> > you can use only
> > BuildRequires:  javapackages-tools
> > or better
> > BuildRequires:  javapackages-local
> > 
> > unnecessary Requires (XMvn handled by XMvn - javapackages-*)
> > Requires:       java-headless >= 1:1.6.0
> > Requires:       javapackages-tools
> > also for sub package javadoc
> > Requires:       %{name} = %{version}-%{release}
> > Requires:       javapackages-tools
> 
> Reading the guidelines[1] I understand they should be exactly as I wrote :-m
> 
> What am I doing wrong?
> 
> [1] https://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires

The reason is that this package is not actually built with maven, so there is
no need to BR the full maven stack. Since you build with javac, you may BR:
javapackages-local instead. If you BR: javapackages-local that will also pull
in java-devel, so you may choose to omit your BR on that too if you wish.

Also the Javadoc subpackage shouldn’t depend on its base package and vice
versa. Please remove "Requires: %{name} = %{version}-%{release}" -- the
rationale for that is that documentation should be readable without installing
half the java stack. ( See
https://fedorahosted.org/released/javapackages/doc/#_javadoc_packages )

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component