[Bug 1086790] Review Request: gnudos - A GNU library to help new users of the GNU system

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1086790



--- Comment #20 from Mohammed Isam <mohammed_isam1984 at yahoo.com> ---
(In reply to Petr Šabata from comment #19)
> I find the %description a little confusing -- at first I wasn't quite sure
> what the difference between your "utilities" and "programs" was and kept
> looking for binaries which weren't there.  Perhaps some rewording would be
> good.

Fixed. Corrected this. I hope the new description is a bit clearer. Utilities
are part of the shared library, and the programs are binaries that are
installed along with the package.

> Update the Texinfo index before the package gets uninstalled, i.e. in a
> %preun section, not %postun.

Fixed. That solved it, it was bugging me because rpm was always complaining on
removing the package.

> Also, your Texinfo files have strange permissions (755).  Remove the
> executable bits.

Fixed. These bit permissions are set by install-info. I changed the files
permission in the %files section.

> Next, a little subjective note -- consider making the SPEC file more
> readable.  An empty line here and there won't hurt (e.g. separate the
> paragraphs in %description, separate %description from other headers,
> separate %changelog entries...)

Fixed. Plenty of empty lines :)

> Packaging aside, a question: your library is called libgnudos-1.6.so* --
> this will make developemt of software using your code fairly uncomfortable
> and I don't think this is what you want.  Unless you really know why you're
> doing this, consider dropping the version from the actual library name.

Fixed. Removed the versioning from the library.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component