[Bug 1169118] Review Request: nodejs-domelementtype - All the types of nodes in htmlparser2's dom

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1169118

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
           Assignee|nobody at fedoraproject.org    |panemade at gmail.com
              Flags|                            |fedora-review?



--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> ---
Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-domelementtype.noarch: W: spelling-error Summary(en_US) dom -> mod, dim,
don
nodejs-domelementtype.noarch: W: spelling-error %description -l en_US dom ->
mod, dim, don
nodejs-domelementtype.noarch: W: only-non-binary-in-usr-lib
nodejs-domelementtype.src: W: spelling-error Summary(en_US) dom -> mod, dim,
don
nodejs-domelementtype.src: W: spelling-error %description -l en_US dom -> mod,
dim, don
2 packages and 0 specfiles checked; 0 errors, 5 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball: 40e96adc53a1535e0cdde455d6b2cfcaf80f459ba825c040e9705dfd49bf64f3
upstream tarball: 
40e96adc53a1535e0cdde455d6b2cfcaf80f459ba825c040e9705dfd49bf64f3

- License is "BSD" but in spec its written "MIT"

+ License test is included in its own LICENSE file.

+ follows nodejs packaging guidelines.

Suggestions:
1) Group tag is optional and can be removed.

2) Fix license tag.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component