[Bug 1171624] Review Request: statismo - C++ Framework for building Statistical Image And Shape Models

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1171624



--- Comment #4 from Antonio Trande <anto.trande at gmail.com> ---
- RPM build system provides a %cmake macro; see the output of command
  'rpm --eval %cmake' to expand it.

- Use 'cmake -LAH' to list all the variables from the CMake including whose
from this project. Use them to set properly %build section on your SPEC file.
For instance, 

BUILD_TESTING:BOOL=
EIGEN3_INCLUDE_DIR:PATH=
...

- All macros mimicking autoconf variables are at
http://fedoraproject.org/wiki/Packaging:RPMMacros

- VTK and ITK libraries are already provided in Fedora; you must erase all
bundled files in the source archive and compile against those system ones.
http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries

- Why parallel make macro is commented? (make -C %{_target_platform} #
%{?_smp_mflags})

- I don't see any License file packaged.

- Your package installs shared libraries in a public directory; it needs
ldconfig tasks.
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries

- At least two executables are not detected:

...
-- Could NOT find Gnuplot (missing:  GNUPLOT_EXECUTABLE) 
-- Could NOT find Wget (missing:  WGET_EXECUTABLE)
..

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component